Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL-1726: Gajira part 6 #1582

Merged
merged 2 commits into from
Oct 7, 2024
Merged

EL-1726: Gajira part 6 #1582

merged 2 commits into from
Oct 7, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

Jira ticket

What changed and why

  • update wording in Jira description
  • add epic/parent link

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@MazOneTwoOne MazOneTwoOne changed the title El-1726: Gajira part 6 EL-1726: Gajira part 6 Oct 7, 2024
@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review October 7, 2024 08:57
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner October 7, 2024 08:57
psweeting1
psweeting1 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MazOneTwoOne MazOneTwoOne merged commit c8aea53 into main Oct 7, 2024
13 checks passed
@MazOneTwoOne MazOneTwoOne deleted the EL-1726-gajira-part-6 branch October 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psweeting1 psweeting1 psweeting1 approved these changes

Assignees
No one assigned
Labels
Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MazOneTwoOne @psweeting1